Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Drag events #124

Merged
merged 22 commits into from
Feb 10, 2025
Merged

Feat: Drag events #124

merged 22 commits into from
Feb 10, 2025

Conversation

lodev09
Copy link
Owner

@lodev09 lodev09 commented Jan 26, 2025

This PR introduces drag events.
See #84

reanimated

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-true-sheet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:27am

@erickreutz
Copy link

erickreutz commented Jan 29, 2025

A question with this - how would we be able to sync this with a SharedValue from reanimated? Something similar to @gorhom/bottom-sheets animatedIndex and animatedPosition props would be great.

@lodev09
Copy link
Owner Author

lodev09 commented Jan 29, 2025

Hi @erickreutz. I believe Reanimated supports this. Like this one for example

@erickreutz
Copy link

Ahh I see, yes that makes sense

@lodev09
Copy link
Owner Author

lodev09 commented Feb 6, 2025

@erickreutz drag events are ready for both IOS and android. However, I did some digging into integrating Reanimated and found out that I need to change the way the native dispatches these events so reanimated can support it.

See this old comment for reference.

@erickreutz
Copy link

@lodev09 lame! you'd think they would have implemented that in the last 4 years

@lodev09
Copy link
Owner Author

lodev09 commented Feb 6, 2025

@erickreutz I know right 😄 . I will adjust and grab code from pager-view for dispatching events. Pager view with reanimated works on the current App I'm working on.

@erickreutz
Copy link

@lodev09 yeah we use that pager view with useEvent in our app as well.

@lodev09 lodev09 marked this pull request as ready for review February 9, 2025 08:17
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 45040 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Feb 9, 2025

Code Climate has analyzed commit a34d598 and detected 0 issues on this pull request.

View more on Code Climate.

@lodev09
Copy link
Owner Author

lodev09 commented Feb 9, 2025

@erickreutz can you give it a quick review? I tried to make it as simple as possible as there are some limitations on both ios & android :/

@erickreutz
Copy link

@lodev09 looks good! Interested to see how this feels in our app

@lodev09 lodev09 merged commit 74ef9b4 into main Feb 10, 2025
6 checks passed
@lodev09 lodev09 deleted the feat/drag-events branch February 10, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants