-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Drag events #124
Feat: Drag events #124
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A question with this - how would we be able to sync this with a |
Hi @erickreutz. I believe Reanimated supports this. Like this one for example |
Ahh I see, yes that makes sense |
@erickreutz drag events are ready for both IOS and android. However, I did some digging into integrating Reanimated and found out that I need to change the way the native dispatches these events so reanimated can support it. See this old comment for reference. |
@lodev09 lame! you'd think they would have implemented that in the last 4 years |
@erickreutz I know right 😄 . I will adjust and grab code from pager-view for dispatching events. Pager view with reanimated works on the current App I'm working on. |
@lodev09 yeah we use that pager view with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 45040 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit a34d598 and detected 0 issues on this pull request. View more on Code Climate. |
@erickreutz can you give it a quick review? I tried to make it as simple as possible as there are some limitations on both ios & android :/ |
@lodev09 looks good! Interested to see how this feels in our app |
This PR introduces drag events.
See #84